lifeSo commented on code in PR #1432:
URL:
https://github.com/apache/incubator-uniffle/pull/1432#discussion_r1449876841
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -142,6 +142,7 @@ public void start() throws Exception {
initMetricsReporter();
registerHeartBeat.startHeartBeat();
+ directMemoryUsageReporter.start();
Review Comment:
Could add test unit case to test the funcation of directMemoryUsageReporter?
Or I could try later.
@rickyma
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -142,6 +142,7 @@ public void start() throws Exception {
initMetricsReporter();
registerHeartBeat.startHeartBeat();
+ directMemoryUsageReporter.start();
Review Comment:
Could add test unit case to test the funcation of directMemoryUsageReporter?
Or I could try later.
##########
server/src/main/java/org/apache/uniffle/server/NettyDirectMemoryTracker.java:
##########
@@ -21,7 +21,7 @@
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
-import io.grpc.netty.shaded.io.netty.util.internal.PlatformDependent;
+import io.netty.util.internal.PlatformDependent;
Review Comment:
What is the difference between the two PlatformDependent?
Or is there problem using
'io.grpc.netty.shaded.io.netty.util.internal.PlatformDependent'
##########
server/src/main/java/org/apache/uniffle/server/NettyDirectMemoryTracker.java:
##########
@@ -21,7 +21,7 @@
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
-import io.grpc.netty.shaded.io.netty.util.internal.PlatformDependent;
+import io.netty.util.internal.PlatformDependent;
Review Comment:
What is the difference between the two PlatformDependent?
Or is there problem using
'io.grpc.netty.shaded.io.netty.util.internal.PlatformDependent'
@rickyma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
