xianjingfeng commented on code in PR #1429:
URL:
https://github.com/apache/incubator-uniffle/pull/1429#discussion_r1452037189
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -352,9 +352,7 @@ public class ShuffleServerConf extends RssBaseConf {
public static final ConfigOption<Long> FALLBACK_MAX_FAIL_TIMES =
ConfigOptions.key("rss.server.hybrid.storage.fallback.max.fail.times")
.longType()
- .checkValue(
- ConfigUtils.NON_NEGATIVE_LONG_VALIDATOR, " fallback times must
be non-negative")
- .defaultValue(0L)
+ .defaultValue(-1L)
Review Comment:
1. What if the users set it to 0.
2. If `!storageManager.canWrite(flushEvent)`, we should ignore retry times.
So should we add a new argument named `force` to
`org.apache.uniffle.server.storage.AbstractStorageManagerFallbackStrategy#tryFallback`
for ignoring retry times. WDYT? @zuston @jerqi
https://github.com/apache/incubator-uniffle/blob/318050144b62c0256c151a278bb04ac73c6e544b/server/src/main/java/org/apache/uniffle/server/storage/hybrid/FallbackBasedStorageManagerSelector.java#L49-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
