rickyma opened a new issue, #1456: URL: https://github.com/apache/incubator-uniffle/issues/1456
### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues. ### What would you like to be improved? Currently, when we call the `ShuffleServerGrpcClient.requirePreAllocation` method, if the internal `getBlockingStub().requireBuffer` throws an exception, it is currently not being caught. We should catch the exception here, log the error, and return `FAILED_REQUIRE_ID`. This would make the `ShuffleServerGrpcClient.requirePreAllocation` method more pure. Also, we need to refactor the code to avoid calling `getBlockingStub().requireBuffer` multiple times. ### How should we improve? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
