zuston commented on PR #1463: URL: https://github.com/apache/incubator-uniffle/pull/1463#issuecomment-1895414296
> > > If you have handled the leak in [#1461](https://github.com/apache/incubator-uniffle/pull/1461), I can close this PR. I didn't look very carefully into your PR, have you handled the leak mentioned in my PR? @zuston > > > > > > No. If you don't mind, please fix this after #1461 is merged. > > I'm ok. I just hope your PR can be merged a bit faster, as I need these patches for testing. :) This fixes the corner case, I don't think It will leak resource on prod. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
