zuston commented on code in PR #1461:
URL:
https://github.com/apache/incubator-uniffle/pull/1461#discussion_r1456741550
##########
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java:
##########
@@ -153,7 +219,7 @@ protected Executor createFlushEventExecutor(int poolSize,
String threadFactoryNa
@Override
public int getEventNumInFlush() {
- return flushQueue.size();
+ return (int) ShuffleServerMetrics.gaugeEventQueueSize.get();
Review Comment:
Could you give some proof? Although I also accept using a independent var to
meet this requirement. And the original impl is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
