jerqi commented on code in PR #1510:
URL:
https://github.com/apache/incubator-uniffle/pull/1510#discussion_r1479358984
##########
proto/src/main/proto/Rss.proto:
##########
@@ -26,6 +26,7 @@ package rss.common;
service ShuffleServer {
rpc registerShuffle (ShuffleRegisterRequest) returns
(ShuffleRegisterResponse);
rpc unregisterShuffle(ShuffleUnregisterRequest) returns
(ShuffleUnregisterResponse);
+ rpc unregisterApp(AppUnregisterRequest) returns (AppUnregisterResponse);
Review Comment:
Prefer using `unregisterShuffleByAppId(String appId);`
Because we don't have registerApp interface. It's weird to use interface
`unregisterApp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
