EnricoMi commented on code in PR #1514:
URL:
https://github.com/apache/incubator-uniffle/pull/1514#discussion_r1484362254
##########
storage/src/main/java/org/apache/uniffle/storage/factory/ShuffleHandlerFactory.java:
##########
@@ -126,6 +126,8 @@ private ClientReadHandler getMemoryClientReadHandler(
Roaring64NavigableMap realExceptBlockIds =
RssUtils.cloneBitMap(request.getExpectBlockIds());
realExceptBlockIds.xor(request.getProcessBlockIds());
expectTaskIds = RssUtils.generateTaskIdBitMap(realExceptBlockIds,
request.getIdHelper());
+ } else {
+ expectTaskIds = request.getExpectTaskIds();
Review Comment:
With `serverInfoList.size() == 1`, the `else` branch is used for TEZ and MR
client. I think expected task ids and those task ids in block ids differ
structurally for those clients. See related code in #1518.
I think with setting `.expectedTaskIdsBitmapFilterEnable(true)` for those
two clients would fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
