jerqi commented on code in PR #1521:
URL:
https://github.com/apache/incubator-uniffle/pull/1521#discussion_r1487056114
##########
common/src/main/java/org/apache/uniffle/common/netty/protocol/Decoders.java:
##########
@@ -47,8 +46,7 @@ public static ShuffleBlockInfo decodeShuffleBlockInfo(ByteBuf
byteBuf) {
long crc = byteBuf.readLong();
long taskAttemptId = byteBuf.readLong();
int dataLength = byteBuf.readInt();
- ByteBuf data =
NettyUtils.getNettyBufferAllocator().directBuffer(dataLength);
- data.writeBytes(byteBuf, dataLength);
+ ByteBuf data = byteBuf.retain().readSlice(dataLength);
Review Comment:
Will byteBuf be spitted into muliple parts? Every part will released
multiple times? Will it bring errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
