rickyma commented on code in PR #1524:
URL:
https://github.com/apache/incubator-uniffle/pull/1524#discussion_r1487390047
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -79,6 +79,8 @@ public class ShuffleServerMetrics {
private static final String USED_BUFFER_SIZE = "used_buffer_size";
private static final String READ_USED_BUFFER_SIZE = "read_used_buffer_size";
private static final String USED_DIRECT_MEMORY_SIZE =
"used_direct_memory_size";
+ private static final String ALLOCATED_DIRECT_MEMORY_SIZE =
"allocated_direct_memory_size";
+ private static final String PINNED_DIRECT_MEMORY_SIZE =
"pinned_direct_memory_size";
Review Comment:
Refer to https://github.com/netty/netty/pull/1166.
To be brief, it means the direct memory actually used by
`PooledByteBufAllocator`, cannot be used anymore. If we use the old metric
`usedDirectMemory`, we cannot tell whether the direct memory is cached by
`PooledByteBufAllocator` or if it's truly exhausted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
