EnricoMi commented on code in PR #1530:
URL:
https://github.com/apache/incubator-uniffle/pull/1530#discussion_r1492031659
##########
dashboard/pom.xml:
##########
@@ -26,6 +26,11 @@
<artifactId>dashboard</artifactId>
<name>Apache Uniffle Dashboard</name>
+
+ <properties>
+ <nodeDownloadRoot>https://nodejs.org/dist/</nodeDownloadRoot>
+ <npmDownloadRoot>https://registry.npmjs.org/npm/-/</npmDownloadRoot>
Review Comment:
Is download root a conventional concept ? This looks like a repository URL,
which is used as the root to construct URLs to fetch packets from. I just think
`Root` is a bit misleading and unnecessarily specific here. What about
```suggestion
<nodeRepositoryUrl>https://nodejs.org/dist/</nodeRepositoryUrl>
<npmRepositoryUrl>https://registry.npmjs.org/npm/-/</npmRepositoryUrl>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
