rickyma commented on code in PR #1531:
URL:
https://github.com/apache/incubator-uniffle/pull/1531#discussion_r1492747192
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBuffer.java:
##########
@@ -47,6 +47,8 @@ public class ShuffleBuffer {
private final long capacity;
private long size;
+ // for Netty mode
+ private long estimatedSize;
Review Comment:
And also, we cannot reuse `size`, because the real size of file will be used
in places like:
`LocalStorageManager`.`updateWriteMetrics`
`HadoopStorageManager`.`updateWriteMetrics`
`ShuffleTaskInfo`.`addOnLocalFileDataSize`
`ShuffleTaskInfo`.`addOnHadoopDataSize`
`StorageWriteMetrics`.`eventSize`
We have to keep it the original way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
