rickyma commented on code in PR #1534:
URL:
https://github.com/apache/incubator-uniffle/pull/1534#discussion_r1497718767
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -80,11 +83,16 @@ public class ShuffleBufferManager {
protected Map<String, Map<Integer, AtomicLong>> shuffleSizeMap =
JavaUtils.newConcurrentMap();
public ShuffleBufferManager(ShuffleServerConf conf, ShuffleFlushManager
shuffleFlushManager) {
+ this.nettyServerEnabled = conf.get(ShuffleServerConf.NETTY_SERVER_PORT) >=
0;
long heapSize = Runtime.getRuntime().maxMemory();
Review Comment:
We allow users to configure the maximum value of the direct memory through
the variable `MAX_DIRECT_MEMORY_SIZE` in the `rss-env.sh` script, so the value
of `PlatformDependent.maxDirectMemory()` may be different from the value of
`Runtime.getRuntime().maxMemory()`, so we cannot merge this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
