jerqi commented on code in PR #1536:
URL:
https://github.com/apache/incubator-uniffle/pull/1536#discussion_r1500157074
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -269,6 +269,10 @@ private int read() {
// because PlatformDependent.freeDirectBuffer can only release the
ByteBuffer with cleaner.
if (sdr != null) {
sdr.release();
+ // We set sdr to null here to prevent IllegalReferenceCountException
that could occur
+ // if sdr.release() is called multiple times in the close() method,
+ // when an exception is thrown by clientReadHandler.readShuffleData().
Review Comment:
I can't get why this will trigger the issue. sdr will be reassign in the
Line 277.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
