EnricoMi commented on code in PR #1532: URL: https://github.com/apache/incubator-uniffle/pull/1532#discussion_r1500790385
########## .github/workflows/docker.yml: ########## @@ -0,0 +1,162 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: Docker example + +on: + workflow_call: + inputs: + java-version: + default: '8' + required: false + type: string + jdk-distro: + default: 'temurin' + required: false + type: string + +jobs: + docker: + runs-on: ubuntu-20.04 + name: speculate fail tasks + steps: + - name: Checkout project + uses: actions/checkout@v3 + - name: Set up JDK ${{ inputs.java-version }} + uses: actions/setup-java@v3 + with: + java-version: ${{ inputs.java-version }} + distribution: ${{ inputs.jdk-distro }} + - name: Cache local Maven repository + uses: actions/cache@v3 + with: + path: ~/.m2/repository + key: mvn-${{ inputs.java-version }}-docker-${{ hashFiles('**/pom.xml') }} + restore-keys: | + mvn-${{ inputs.java-version }}-docker- + - name: Build the docker images + run: ./deploy/docker/build.sh + shell: bash + - name: Start the docker cluster + id: up + run: | + docker compose -f deploy/docker/docker-compose.yml up --detach --scale shuffle-server=4 --scale spark-worker=5 + + # for some reason, the uniffle containers terminate after first creation Review Comment: I have found the issue. The `start.sh` script gave the process 10 seconds to start. Starting 5 containers at once on the [hardware spec used by GHA](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) turns out to take more than those 10 seconds. I have reworked the starts script and the way the CI waits for the containers to come up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
