rickyma commented on code in PR #1547:
URL:
https://github.com/apache/incubator-uniffle/pull/1547#discussion_r1504064099
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java:
##########
@@ -166,7 +166,7 @@ private int uncompress(CompressedShuffleBlock rawBlock,
ByteBuffer rawData) {
|| !isSameMemoryType(uncompressedData, rawData)) {
if (LOG.isDebugEnabled()) {
- if (!isSameMemoryType(uncompressedData, rawData)) {
+ if (uncompressedData != null && !isSameMemoryType(uncompressedData,
rawData)) {
Review Comment:
`rawData` will not be null. Because the code is something like:
```
public boolean hasNext() {
...
if (rawData != null) {
uncompress(rawBlock, rawData);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
