rickyma commented on code in PR #1595:
URL: 
https://github.com/apache/incubator-uniffle/pull/1595#discussion_r1533731790


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -268,6 +270,20 @@ public void sendShuffleData(
                 + spd.getPartitionId()
                 + "]";
         try {
+          isShuffleIdDeleted =

Review Comment:
   I think a new `appId` and `shuffleId` will be already registered during the 
`registerShuffle` phase, which means `isShuffleIdDeleted` will be false when a 
new application arrives. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to