jerqi commented on code in PR #1604:
URL:
https://github.com/apache/incubator-uniffle/pull/1604#discussion_r1538755426
##########
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java:
##########
@@ -209,4 +209,10 @@ public class RssClientConf {
.defaultValue(false)
.withDescription(
"Whether to support task write failed retry internal, default
value is false.");
+
+ public static final ConfigOption<Integer>
RSS_CLIENT_REGISTER_SHUFFLE_MAX_PARALLELISM =
+ ConfigOptions.key("rss.client.registerShuffle.maxParallelism")
Review Comment:
Our config options aren't good enough. Some config options have bad name.
Maybe we should refactor them.
I thinks we should use `rss.client.group.camelStyleConfigOption`. I prefer
using `rss.client.rpc.maxRegisterParallelism`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
