zuston commented on code in PR #1605:
URL:
https://github.com/apache/incubator-uniffle/pull/1605#discussion_r1540542942
##########
server/src/main/java/org/apache/uniffle/server/netty/ShuffleServerNettyHandler.java:
##########
@@ -361,12 +356,11 @@ public void handleGetLocalShuffleIndexRequest(
response =
new GetLocalShuffleIndexResponse(
req.getRequestId(), status, msg, data,
shuffleIndexResult.getDataFileLen());
- long readTime = System.currentTimeMillis() - start;
- LOG.info(
- "Successfully getShuffleIndex cost {} ms for {}" + " bytes with
{}",
- readTime,
- data.size(),
- requestInfo);
+ ReleaseMemoryAndRecordReadTimeListener listener =
+ new ReleaseMemoryAndRecordReadTimeListener(
+ start, assumedFileSize, data.size(), requestInfo, req, client);
+ client.getChannel().writeAndFlush(response).addListener(listener);
+ return;
} catch (FileNotFoundException indexFileNotFoundException) {
LOG.warn(
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/netty/ShuffleServerNettyHandler.java:
##########
@@ -459,29 +449,23 @@ public void handleGetLocalShuffleData(TransportClient
client, GetLocalShuffleDat
storageType,
offset,
length);
- long readTime = System.currentTimeMillis() - start;
- ShuffleServerMetrics.counterTotalReadTime.inc(readTime);
ShuffleServerMetrics.counterTotalReadDataSize.inc(sdr.getDataLength());
ShuffleServerMetrics.counterTotalReadLocalDataFileSize.inc(sdr.getDataLength());
- shuffleServer
- .getNettyMetrics()
- .recordProcessTime(GetLocalShuffleDataRequest.class.getName(),
readTime);
- LOG.info(
- "Successfully getShuffleData cost {} ms for shuffle" + " data with
{}",
- readTime,
- requestInfo);
response =
new GetLocalShuffleDataResponse(
req.getRequestId(), status, msg, sdr.getManagedBuffer());
+ ReleaseMemoryAndRecordReadTimeListener listener =
+ new ReleaseMemoryAndRecordReadTimeListener(
+ start, length, sdr.getDataLength(), requestInfo, req, client);
+ client.getChannel().writeAndFlush(response).addListener(listener);
+ return;
} catch (Exception e) {
status = StatusCode.INTERNAL_ERROR;
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/netty/ShuffleServerNettyHandler.java:
##########
@@ -281,18 +283,13 @@ public void handleGetMemoryShuffleDataRequest(
ShuffleServerMetrics.counterTotalReadDataSize.inc(data.size());
ShuffleServerMetrics.counterTotalReadMemoryDataSize.inc(data.size());
}
- long costTime = System.currentTimeMillis() - start;
- shuffleServer
- .getNettyMetrics()
- .recordProcessTime(GetMemoryShuffleDataRequest.class.getName(),
costTime);
- LOG.info(
- "Successfully getInMemoryShuffleData cost {} ms with {} bytes
shuffle" + " data for {}",
- costTime,
- data.size(),
- requestInfo);
-
response =
new GetMemoryShuffleDataResponse(req.getRequestId(), status, msg,
bufferSegments, data);
+ ReleaseMemoryAndRecordReadTimeListener listener =
+ new ReleaseMemoryAndRecordReadTimeListener(
+ start, readBufferSize, data.size(), requestInfo, req, client);
+ client.getChannel().writeAndFlush(response).addListener(listener);
+ return;
} catch (Exception e) {
status = StatusCode.INTERNAL_ERROR;
Review Comment:
Here haven't release the read memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
