zuston commented on PR #1627: URL: https://github.com/apache/incubator-uniffle/pull/1627#issuecomment-2044198433
From my side, the `eventOfUnderStorageManagers` cache is not a good design, which depends on the storage manager selector being idempotent for the same event. However we don't ensure this, especially for the partial storageManager unhealthy or corrupted. Based on the upon thought, this PR is not a good solution to solve this. If we bound the selected storage manager into the event, will the problem be sloved? WDYT @rickyma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
