jerqi commented on code in PR #1627:
URL:
https://github.com/apache/incubator-uniffle/pull/1627#discussion_r1558836405
##########
server/src/main/java/org/apache/uniffle/server/storage/HybridStorageManager.java:
##########
@@ -129,17 +121,12 @@ public void updateWriteMetrics(ShuffleDataFlushEvent
event, long writeTime) {
private StorageManager selectStorageManager(ShuffleDataFlushEvent event) {
StorageManager storageManager = storageManagerSelector.select(event);
- eventOfUnderStorageManagers.put(event, storageManager);
- event.addCleanupCallback(() ->
eventOfUnderStorageManagers.invalidate(event));
return storageManager;
}
@Override
public boolean write(Storage storage, ShuffleWriteHandler handler,
ShuffleDataFlushEvent event) {
- StorageManager underStorageManager =
eventOfUnderStorageManagers.getIfPresent(event);
- if (underStorageManager == null) {
- return false;
- }
+ StorageManager underStorageManager = selectStorageManager(event);
Review Comment:
OK. I remember it wrongly. I ever thought it will use different
LocalStorageManagers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
