zuston opened a new issue, #1634:
URL: https://github.com/apache/incubator-uniffle/issues/1634

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   I found some shuffle-servers basic dir has lots of app folders remains wich 
has been expired.
   
   After digging this case, I think this is caused by the children shuffleIds 
unregistering. Please see here: 
https://github.com/apache/incubator-uniffle/blob/a7a0b4ce41a213f8f3e05a1e1198c41857706229/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java#L778-#L781
 .
   
   Once one app's all shuffleIds has been unregistered by the 
`ShufflePurgeEvent`, the above code will be invalid, because 
`shuffleToCachedBlockIds` will be empty and them won't trigger the 
removeResource by app level. So the app folder still remains after expire.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to