zuston commented on code in PR #1646:
URL:
https://github.com/apache/incubator-uniffle/pull/1646#discussion_r1566623709
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -720,6 +722,8 @@ public void getLocalShuffleData(
sdr.release();
}
shuffleServer.getShuffleBufferManager().releaseReadMemory(length);
+ ShuffleServerMetrics.gaugeReadLocalDataFileThreadNum.dec();
Review Comment:
This is not accurate to dec metric here, because the `sdr =
shuffleServer.getShuffleTaskManager().getShuffleData` will throw exception
before the `inc` happen.
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -810,6 +819,8 @@ public void getLocalShuffleIndex(
shuffleIndexResult.release();
}
shuffleServer.getShuffleBufferManager().releaseReadMemory(assumedFileSize);
+ ShuffleServerMetrics.gaugeReadLocalIndexFileThreadNum.dec();
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
