EnricoMi commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1568281993
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -563,24 +582,23 @@ private void clearFailedBlockState(ShuffleBlockInfo
block) {
partitionLengths[block.getPartitionId()] -= block.getLength();
}
- private ShuffleServerInfo reassignFaultyShuffleServer(
- Set<Integer> partitionIds, String faultyServerId) {
+ private void triggerReassignShuffleServer(
+ Set<Integer> partitionIds, String faultyServerId, Set<Integer>
needLoadBalancePartitions) {
Review Comment:
I think `needLoadBalancePartitions` can be simplified to
`loadBalancePartitions`, there is no benefit in adding `need`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
