EnricoMi commented on code in PR #1615: URL: https://github.com/apache/incubator-uniffle/pull/1615#discussion_r1568321670
########## client/src/main/java/org/apache/uniffle/client/PartitionDataReplicaRequirementTracking.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.client; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.uniffle.common.ShuffleServerInfo; + +/** + * This class is to track the partition data replica requirements, which is used for {@link + * org.apache.uniffle.client.impl.ShuffleWriteClientImpl} to check whether the reading blockIds from + * multi/single server(s) meet the min replica. + */ +public class PartitionDataReplicaRequirementTracking { + private int shuffleId; + + // partitionId -> replicaIndex -> shuffleServerInfo + private Map<Integer, Map<Integer, List<ShuffleServerInfo>>> inventory; + + private Map<Integer, Map<Integer, Integer>> succeedList = new HashMap<>(); + + public PartitionDataReplicaRequirementTracking( + int shuffleId, Map<Integer, Map<Integer, List<ShuffleServerInfo>>> inventory) { + this.shuffleId = shuffleId; + this.inventory = inventory; + } + + public boolean isSatisfied(int partitionId, int minReplica) { + // replica index -> successful count + Map<Integer, Integer> succeedReplicas = succeedList.get(partitionId); + if (succeedReplicas == null) { + succeedReplicas = new HashMap<>(); + } + + Map<Integer, List<ShuffleServerInfo>> replicaList = inventory.get(partitionId); Review Comment: What if `partitionId` does not exist? ########## client/src/main/java/org/apache/uniffle/client/PartitionDataReplicaRequirementTracking.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.client; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.uniffle.common.ShuffleServerInfo; + +/** + * This class is to track the partition data replica requirements, which is used for {@link + * org.apache.uniffle.client.impl.ShuffleWriteClientImpl} to check whether the reading blockIds from + * multi/single server(s) meet the min replica. + */ +public class PartitionDataReplicaRequirementTracking { + private int shuffleId; + + // partitionId -> replicaIndex -> shuffleServerInfo + private Map<Integer, Map<Integer, List<ShuffleServerInfo>>> inventory; + + private Map<Integer, Map<Integer, Integer>> succeedList = new HashMap<>(); + + public PartitionDataReplicaRequirementTracking( + int shuffleId, Map<Integer, Map<Integer, List<ShuffleServerInfo>>> inventory) { + this.shuffleId = shuffleId; + this.inventory = inventory; + } + + public boolean isSatisfied(int partitionId, int minReplica) { + // replica index -> successful count + Map<Integer, Integer> succeedReplicas = succeedList.get(partitionId); + if (succeedReplicas == null) { + succeedReplicas = new HashMap<>(); + } Review Comment: This can be simplified: ``` Map<Integer, Integer> succeedReplicas = succeedList.getOrDefault(partitionId, new HashMap<>()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
