EnricoMi commented on code in PR #1663:
URL:
https://github.com/apache/incubator-uniffle/pull/1663#discussion_r1571797581
##########
client-spark/common/src/test/java/org/apache/uniffle/shuffle/manager/ShuffleManagerServerFactoryTest.java:
##########
@@ -22,21 +22,16 @@
import org.apache.uniffle.common.config.RssBaseConf;
import org.apache.uniffle.common.rpc.ServerType;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-
public class ShuffleManagerServerFactoryTest {
@Test
public void testShuffleManagerServerType() {
Review Comment:
Could we use `@ParameterizedTest` and provide the server types as test
parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
