dingshun3016 commented on PR #1636: URL: https://github.com/apache/incubator-uniffle/pull/1636#issuecomment-2071518262
> Thanks for adding detailed logs, I have understood your point, the root cause is to partition shuffle reader handler is cached. After the memory data is flushed into local file, the cached read handler don't recognized this case and ignore it. > > But from my side, I don't think your code running in your producation env is the same with the current upstream master code. In current uniffle master code, if the indexFile is not found, it will throw exception, so the log may not the same. > > Based the above suppose, I think we just to handle the `map.computeIfAbsent(partitionKey, key -> newReadHandler(request));` carefully and you can throw exception if no index file. After thinking about it, I think throwing exception may cause call `getLocalShuffleData` to fail. @zuston -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
