xumanbu commented on code in PR #1659:
URL:
https://github.com/apache/incubator-uniffle/pull/1659#discussion_r1582586097
##########
common/src/main/java/org/apache/uniffle/common/netty/buffer/FileSegmentManagedBuffer.java:
##########
@@ -39,6 +39,8 @@ public class FileSegmentManagedBuffer extends ManagedBuffer {
private final File file;
private final long offset;
private final int length;
+ private boolean isFilled;
Review Comment:
The `readByteBuffer` may be allocated but not filled with bytes, indicating
a failure to read the file. Therefore, I believe adding another state for
reliability is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
