zuston commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1590508455
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -64,6 +64,19 @@ public class RssSparkConfig {
.withDescription(
"The memory spill switch triggered by Spark TaskMemoryManager,
default value is false.");
+ public static final ConfigOption<Integer>
RSS_PARTITION_REASSIGN_MAX_REASSIGNMENT_SERVER_NUM =
+ ConfigOptions.key("rss.client.partitionReassign.maxReassignServerNum")
+ .intType()
+ .defaultValue(10)
+ .withDescription(
+ "The max reassign server num for one partition when using
partition reassign mechanism.");
+
+ public static final ConfigOption<Integer>
RSS_PARTITION_REASSIGN_BLOCK_RETRY_MAX_TIMES =
Review Comment:
done
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -125,9 +130,11 @@ public class RssShuffleWriter<K, V, C> extends
ShuffleWriter<K, V> {
private final BlockingQueue<Object> finishEventQueue = new
LinkedBlockingQueue<>();
- // shuffleServerId -> failoverShuffleServer
- private final Map<String, ShuffleServerInfo> replacementShuffleServers =
- JavaUtils.newConcurrentMap();
+ // Will be updated when the reassignment is triggered.
+ private TaskAttemptAssignment taskAttemptAssignment;
+
+ private static final Set<StatusCode>
ILLEGAL_STATUS_CODE_WITHOUT_BLOCK_RESEND =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
