jerqi commented on PR #1679: URL: https://github.com/apache/incubator-uniffle/pull/1679#issuecomment-2101855476
> > > > This is another case and that is why I prefer not using the disk size that uniffle maintained. > > > > > > > > > Here we have calculated the space usage of the server, could we use it for judgment? @jerqi @zuston > > > https://github.com/apache/incubator-uniffle/blob/43bd09c652889919ad888d31d4e3a5461c93f21d/server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java#L116 > > > > > > This can't handle mix deployment with other services. > > No, it can. > > https://github.com/apache/incubator-uniffle/blob/43bd09c652889919ad888d31d4e3a5461c93f21d/server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java#L200-L224 Ok for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
