rickyma commented on code in PR #1687:
URL:
https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595463308
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to
MetricSystem (ms)");
+ public static final ConfigOption<Long>
SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+
ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
I followed the name
`rss.server.netty.directMemoryTracker.memoryUsage.updateMetricsIntervalMs`.
Maybe `rss.server.netty.pending.tasks.num.polling.interval`? If we continue
to simplify the naming of this variable, I'm afraid it might become difficult
to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
