xianjingfeng commented on code in PR #1681:
URL:
https://github.com/apache/incubator-uniffle/pull/1681#discussion_r1596432177
##########
storage/src/main/java/org/apache/uniffle/storage/handler/api/ShuffleDeleteHandler.java:
##########
@@ -24,5 +24,5 @@ public interface ShuffleDeleteHandler {
*
* @param appId ApplicationId for delete
*/
- void delete(String[] storageBasePaths, String appId, String user);
+ void delete(String[] storageBasePaths, String appId, String user, String
shuffleServerId);
Review Comment:
> Why? From my side, this operation could be applied to all app purge, not
only for expire app
For performance. Deleting the application directory only requires one
request to namenode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
