zuston commented on code in PR #1617:
URL:
https://github.com/apache/incubator-uniffle/pull/1617#discussion_r1596693993
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -428,6 +428,20 @@ public void finishShuffle(
public void requireBuffer(
RequireBufferRequest request, StreamObserver<RequireBufferResponse>
responseObserver) {
String appId = request.getAppId();
+ if (shuffleServer.isActivateClientPartitionReassign()
+ && shuffleServer
+ .getShuffleTaskManager()
+ .getShuffleTaskInfo(appId)
+ .isBlockFailureReassignEnabled()) {
+ responseObserver.onNext(
+ RequireBufferResponse.newBuilder()
+ .setStatus(StatusCode.SERVER_INACTIVE.toProto())
+ .setRetMsg("Server is inactive, status: " +
shuffleServer.getServerStatus())
+ .build());
+ responseObserver.onCompleted();
+ return;
+ }
+
Review Comment:
> In our production environment, our health check uses HealthScriptChecker.
The server is not healthy very frequently, such as high load or high network
card traffic or disk utilization triggering threshold, etc.
Yes, I introduced the extra config to control whether to enable this
feature. So you could disable this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
