LuciferYang commented on code in PR #1700:
URL:
https://github.com/apache/incubator-uniffle/pull/1700#discussion_r1602770442
##########
server/pom.xml:
##########
@@ -129,13 +129,12 @@
</exclusions>
</dependency>
<dependency>
- <groupId>commons-collections</groupId>
- <artifactId>commons-collections</artifactId>
- <version>${commons-collections.version}</version>
+ <groupId>org.apache.commons</groupId>
Review Comment:
> The UTs have all passed, so the casading dependencies should be OK.
OK. It would be even better if we could double check this through the
dependency tree.
> I just changed the order of the dependencies. commons-lang3 remains the
same as before.
Can we maintain the original order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
