advancedxy commented on code in PR #1720:
URL:
https://github.com/apache/incubator-uniffle/pull/1720#discussion_r1605662645
##########
bin/start-coordinator.sh:
##########
@@ -81,7 +81,7 @@ JVM_ARGS=" -server \
-Xloggc:${RSS_LOG_DIR}/gc-%t.log"
JAVA11_EXTRA_ARGS=" -XX:+IgnoreUnrecognizedVMOptions \
- -Xlog:gc:tags,time,uptime,level"
+
-Xlog:gc=trace:file=${RSS_LOG_DIR}/gc-%t.log:tags,time,uptime,level:filecount=10,filesize=100m"
Review Comment:
Two minor questions:
1. just to want to make sure: what does `trace` actually mean, is it a
recommend practice to set to trace?
2. Do you test it with java11+ and it creates correct gc logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
