EnricoMi commented on PR #1714: URL: https://github.com/apache/incubator-uniffle/pull/1714#issuecomment-2120114236
You are right @rickyma. An executor finishes by calling close / shutdown and then may terminate. That interrupts waiting threads and causes ongoing calls to throw exceptions. Since close / shutdown has been called, we don't want those exceptions to be logged as errors / warns. There are two options 1) wait gracefully for the open requests to complete or timeout, but this defers the executor termination, which might not be desired 2) terminate the executor quickly while relying on clean-up mechanisms (current behaviour) We don't care about the heartbeats, and shuffles are cleaned-up after some timeout anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
