EnricoMi commented on PR #1714: URL: https://github.com/apache/incubator-uniffle/pull/1714#issuecomment-2126676535
> > By the time `close` is called, all threads are completed. > > If I'm correct, this is not guaranteed. These are different ExecutorServices. Let me rephrase this: By the time `ShuffleWriteClientImpl.unregisterShuffle` returns, all unregister requests completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
