jerqi commented on code in PR #1240:
URL:
https://github.com/apache/incubator-uniffle/pull/1240#discussion_r1611386425
##########
bin/start-coordinator.sh:
##########
@@ -92,7 +93,17 @@ else
exit 1
fi
-$RUNNER $ARGS $JVM_ARGS $JAVA11_EXTRA_ARGS -cp $CLASSPATH $MAIN_CLASS --conf
"$COORDINATOR_CONF_FILE" $@ &
+version=$($RUNNER -version 2>&1 | awk -F '"' '/version/ {print $2}')
+if [[ $version == "1.8"* ]]; then
+ GC_ARGS=$JAVA8_GC_ARGS
+elif [[ $version == "11"* ]]; then
+ GC_ARGS=$JAVA11_GC_ARGS
+else
Review Comment:
We support JDK 17, too. VIP use JDK 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
