rickyma commented on code in PR #1738:
URL:
https://github.com/apache/incubator-uniffle/pull/1738#discussion_r1611764413
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -976,15 +1012,17 @@ public void unregisterShuffle(String appId, int
shuffleId) {
ShuffleServerClientFactory.getInstance()
.getShuffleServerClient(clientType, shuffleServerInfo,
rssConf);
RssUnregisterShuffleResponse response =
client.unregisterShuffle(request);
- if (response.getStatusCode() != StatusCode.SUCCESS) {
- LOG.warn("Failed to unregister shuffle to " +
shuffleServerInfo);
+ if (response.getStatusCode() == StatusCode.SUCCESS) {
+ LOG.info("Successfully unregistered shuffle from {}",
shuffleServerInfo);
+ } else {
+ LOG.warn("Failed to unregister shuffle from {}",
shuffleServerInfo);
}
} catch (Exception e) {
- LOG.warn("Error happened when unregistering to " +
shuffleServerInfo, e);
+ LOG.warn("Error happened when unregistering from " +
shuffleServerInfo, e);
Review Comment:
We can refactor this using `{}`. It will be better.
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -191,6 +191,10 @@ public class RssSparkConfig {
createIntegerBuilder(new
ConfigBuilder("spark.rss.client.unregister.thread.pool.size"))
.createWithDefault(10);
+ public static final ConfigEntry<Integer> RSS_CLIENT_UNREGISTER_TIMEOUT_SEC =
+ createIntegerBuilder(new
ConfigBuilder("spark.rss.client.unregister.timeout.sec"))
+ .createWithDefault(60);
Review Comment:
We can add a description using `withDescription`.
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -1024,15 +1087,17 @@ public void unregisterShuffle(String appId) {
.getShuffleServerClient(clientType, shuffleServerInfo,
rssConf);
RssUnregisterShuffleByAppIdResponse response =
client.unregisterShuffleByAppId(request);
- if (response.getStatusCode() != StatusCode.SUCCESS) {
- LOG.warn("Failed to unregister shuffle to " +
shuffleServerInfo);
+ if (response.getStatusCode() == StatusCode.SUCCESS) {
+ LOG.info("Successfully unregistered shuffle from {}",
shuffleServerInfo);
+ } else {
+ LOG.warn("Failed to unregister shuffle from {}",
shuffleServerInfo);
}
} catch (Exception e) {
- LOG.warn("Error happened when unregistering to " +
shuffleServerInfo, e);
+ LOG.warn("Error happened when unregistering from " +
shuffleServerInfo, e);
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
