xianjingfeng commented on PR #1759: URL: https://github.com/apache/incubator-uniffle/pull/1759#issuecomment-2144576339
> I think this PR will be enough for most small blocks cases. Flush while block number reach threshold means that we can't make full use of memory. This pr is ok for me, but it is not suitable for our production environment. We want to assign 1.2t memory to a single shuffle server, but now we just assign 350G to them because of GC pressure. > I've changed `Fix` to `For`. Is that okay for you? :) Ok for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
