zuston commented on code in PR #1761:
URL:
https://github.com/apache/incubator-uniffle/pull/1761#discussion_r1624081521
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -270,8 +270,8 @@ private void writeImpl(Iterator<Product2<K, V>> records) {
long s = System.currentTimeMillis();
checkAllBufferSpilled();
checkSentRecordCount(recordCount);
+ checkBlockSendResult(new HashSet<>(blockIds));
Review Comment:
The variant of `blockIds` will be used for the `checkSentBlockIds` , so it's
better to avoid modification in `checkBlockSendResult`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
