rickyma commented on code in PR #1763:
URL:
https://github.com/apache/incubator-uniffle/pull/1763#discussion_r1627297006
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -430,7 +430,9 @@ public class ShuffleServerConf extends RssBaseConf {
.withDescription(
"The type for shuffle buffers. Setting as LINKED_LIST or
SKIP_LIST."
+ "The default value is LINKED_LIST. SKIP_LIST will help to
improve"
- + "the performance, but it don't support the show start
feature of MR");
+ + "the performance especially when allocating a large amount
of memory"
Review Comment:
Oh yeah, this is another performance improvement, or maybe we can update it
like:
SKIP_LIST will help to improve the performance when there are a large number
of blocks in memory or when the memory occupied by the blocks is very large.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
