zuston commented on code in PR #1759:
URL:
https://github.com/apache/incubator-uniffle/pull/1759#discussion_r1627351780
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -387,12 +387,24 @@ public class ShuffleServerConf extends RssBaseConf {
.withDescription(
"Whether single buffer flush when size exceeded
rss.server.single.buffer.flush.threshold");
- public static final ConfigOption<Long> SINGLE_BUFFER_FLUSH_THRESHOLD =
+ public static final ConfigOption<Long> SINGLE_BUFFER_FLUSH_SIZE_THRESHOLD =
ConfigOptions.key("rss.server.single.buffer.flush.threshold")
.longType()
.defaultValue(128 * 1024 * 1024L)
.withDescription("The threshold of single shuffle buffer flush");
+ public static final ConfigOption<Integer>
SINGLE_BUFFER_FLUSH_BLOCKS_NUM_THRESHOLD =
+ ConfigOptions.key("rss.server.single.buffer.flush.blocksNumberThreshold")
+ .intType()
+ .defaultValue(4000)
Review Comment:
I want to know whether this default value will not make us full use of the
memory? Do we have some extra metrics to recognize this if this is set by
default ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
