yl09099 commented on code in PR #1449:
URL:
https://github.com/apache/incubator-uniffle/pull/1449#discussion_r1627672331
##########
dashboard/src/main/webapp/package.json:
##########
@@ -32,6 +32,7 @@
"core-js": "^3.8.3",
"element-plus": "^2.3.6",
"moment": "^2.29.4",
+ "pinia": "^2.1.7",
Review Comment:
> I suggest remove `pinia`, we can just use `localStorage`. @yl09099 @zuston
@rickyma PTAL
In this case, a global store is required to monitor the address change of
the entire page, and localStorage cannot be used, which cannot monitor the
change of the requested address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
