xianjingfeng commented on code in PR #1862:
URL:
https://github.com/apache/incubator-uniffle/pull/1862#discussion_r1666152445
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -226,8 +226,11 @@ private void parseExcludeNodesFile(DataInputStream
fsDataInputStream) throws IOE
public void add(ServerNode node) {
if (!servers.containsKey(node.getId())) {
LOG.info("Newly registering node: {}", node.getId());
+ servers.put(node.getId(), node);
+ } else {
+ servers.get(node.getId()).update(node);
}
Review Comment:
```suggestion
ServerNode previousNode = servers.get(node.getId());
if (previousNode == null) {
LOG.info("Newly registering node: {}", node.getId());
} else {
node.setRegistrationTime(previousNode.getRegistrationTime());
}
servers.put(node.getId(), node);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
