xianjingfeng commented on code in PR #1868: URL: https://github.com/apache/incubator-uniffle/pull/1868#discussion_r1669938447
########## dashboard/src/main/webapp/src/pages/serverstatus/ListPage.vue: ########## @@ -0,0 +1,175 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<template> + <div> + <el-table + :data="listPageData.tableData" + height="550" + style="width: 100%" + :default-sort="sortColumn" + @sort-change="sortChangeEvent" + > + <el-table-column prop="id" label="Id" min-width="140" sortable fixed /> + <el-table-column prop="ip" label="IP" min-width="80" sortable /> + <el-table-column prop="grpcPort" label="Port" min-width="80" /> + <el-table-column prop="nettyPort" label="NettyPort" min-width="80" /> + <el-table-column + prop="usedMemory" + label="UsedMem" + min-width="80" + :formatter="memFormatter" + sortable + /> + <el-table-column + prop="preAllocatedMemory" + label="PreAllocatedMem" + min-width="100" + :formatter="memFormatter" + sortable + /> + <el-table-column + prop="availableMemory" + label="AvailableMem" + min-width="80" + :formatter="memFormatter" + sortable + /> + <el-table-column prop="eventNumInFlush" label="FlushNum" min-width="80" sortable /> + <el-table-column prop="status" label="Status" min-width="80" sortable /> + <el-table-column + prop="registrationTime" + label="RegistrationTime" + min-width="120" + :formatter="dateFormatter" + /> + <el-table-column + prop="timestamp" + label="HeartbeatTime" + min-width="120" + :formatter="dateFormatter" + sortable + /> + <el-table-column prop="tags" label="Tags" min-width="140" /> + </el-table> + </div> +</template> +<script> +import { onMounted, reactive, watch } from 'vue' +import { memFormatter, dateFormatter } from '@/utils/common' +import { + getShuffleActiveNodes, + getShuffleDecommissionedList, + getShuffleDecommissioningList, + getShuffleLostList, + getShuffleUnhealthyList +} from '@/api/api' +import { useRouter } from 'vue-router' +import { useCurrentServerStore } from '@/store/useCurrentServerStore' + +export default { + setup() { + const router = useRouter() + const currentServerStore = useCurrentServerStore() + const sortColumn = reactive({}) + const listPageData = reactive({ + tableData: [ + { + id: '', + ip: '', + grpcPort: 0, + nettyPort: 0, + usedMemory: 0, + preAllocatedMemory: 0, + availableMemory: 0, + eventNumInFlush: 0, + tags: '', + status: '', + registrationTime: '', + timestamp: '' + } + ] + }) + + async function getShuffleActiveNodesPage() { + const res = await getShuffleActiveNodes() + listPageData.tableData = res.data.data + } + + async function getShuffleDecommissionedListPage() { + const res = await getShuffleDecommissionedList() + listPageData.tableData = res.data.data + } + + async function getShuffleDecommissioningListPage() { + const res = await getShuffleDecommissioningList() + listPageData.tableData = res.data.data + } + + async function getShuffleLostListPage() { + const res = await getShuffleLostList() + listPageData.tableData = res.data.data + } + + async function getShuffleUnhealthyListPage() { + const res = await getShuffleUnhealthyList() + listPageData.tableData = res.data.data + } + + onMounted(() => { + // If the coordinator address to request is not found in the global variable, the request is not initiated. + if (currentServerStore.currentServer) { + if (router.currentRoute.value.name === 'activeNodeList') { + getShuffleActiveNodesPage() + } else if (router.currentRoute.value.name === 'decommissioningNodeList') { + getShuffleDecommissioningListPage() + } else if (router.currentRoute.value.name === 'decommissionedNodeList') { + getShuffleDecommissionedListPage() + } else if (router.currentRoute.value.name === 'unhealthyNodeList') { + getShuffleUnhealthyListPage() + } else if (router.currentRoute.value.name === 'lostNodeList') { + getShuffleLostListPage() + } + } + }) + + watch(router.currentRoute, () => { + if (currentServerStore.currentServer) { + if (router.currentRoute.value.name === 'activeNodeList') { + getShuffleActiveNodesPage() + } else if (router.currentRoute.value.name === 'decommissioningNodeList') { + getShuffleDecommissioningListPage() + } else if (router.currentRoute.value.name === 'decommissionedNodeList') { + getShuffleDecommissionedListPage() + } else if (router.currentRoute.value.name === 'unhealthyNodeList') { + getShuffleUnhealthyListPage() + } else if (router.currentRoute.value.name === 'lostNodeList') { + getShuffleLostListPage() + } Review Comment: Could you create a function for this part of code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
