dingshun3016 commented on PR #1878: URL: https://github.com/apache/incubator-uniffle/pull/1878#issuecomment-2217724334
> @jerqi Thanks for noticed this PR, the main mind of this PR aimed to include all dependencies first and excludes or make dependencies `Provided` scope, so we can make sure what dependencies are excluded by us explicitly. > > As before, we include some of dependencies, and we relocated within these dependencies, after that, we involved more dependencies directly or indirectly, but we may miss to include them, so the ClassNotFoundExceptions encountered in a random time. This may not relocated enough. If some other packages are introduced later but not shaded, this will also cause conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
