rickyma commented on code in PR #1889:
URL:
https://github.com/apache/incubator-uniffle/pull/1889#discussion_r1673329941
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -308,6 +308,21 @@ protected static int getMaxConcurrencyWriting(
public StatusCode cacheShuffleData(
String appId, int shuffleId, boolean isPreAllocated,
ShufflePartitionedData spd) {
refreshAppId(appId);
+ long partitionSize = getPartitionDataSize(appId, shuffleId,
spd.getPartitionId());
+ long deltaSize = 0L;
+ for (ShufflePartitionedBlock spb : spd.getBlockList()) {
+ deltaSize += spb.getSize();
+ }
+ partitionSize += deltaSize;
+ if (shuffleBufferManager.isPartitionExceededMaxSize(partitionSize)) {
+ throw new InvalidRequestException(
Review Comment:
We need to return a new `StatusCode` instead of throwing an exception. When
the client receive the new `StatusCode`, it should throw a `NotRetryException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
