kuszz commented on code in PR #1876:
URL:
https://github.com/apache/incubator-uniffle/pull/1876#discussion_r1677378642
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java:
##########
@@ -145,12 +145,12 @@ public void registerApplicationInfo(String appId, String
user) {
}
}
- public void refreshAppId(String appId) {
- String user = appIdToUser.get(appId);
+ public void refreshAppId(String appId, String user) {
// compatible with lower version clients
- if (user == null) {
Review Comment:
> How to handle the case `user == null`? Because there may be existing
legacy clients.
When the user field is not specified in legacy clients, the value will be
empty instead of null. So if coordinator restarts, it actually calls
registerApplicationInfo(appId, "").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
