yl09099 commented on code in PR #1897:
URL:
https://github.com/apache/incubator-uniffle/pull/1897#discussion_r1677441533
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/ServerResource.java:
##########
@@ -181,13 +190,18 @@ public Response<Map<String, Integer>>
getNodeStatusTotal() {
return execute(
() -> {
ClusterManager clusterManager = getClusterManager();
+ List<ServerNode> serverAllList = clusterManager.list();
List<ServerNode> excludeNodes =
clusterManager.getExcludeNodes().stream()
.map(exclude -> new ServerNode(exclude))
.collect(Collectors.toList());
+ List<ServerNode> activeServerList =
+ serverAllList.stream()
+ .filter(node -> !excludeNodes.contains(node))
+ .collect(Collectors.toList());
Map<String, Integer> stringIntegerHash =
Stream.of(
- clusterManager.list(),
+ activeServerList,
clusterManager.getLostServerList(),
excludeNodes,
Review Comment:
> Would it be the same if we just deleted this line?
The list() method gets all the server nodes, but the server nodes do not
have a exclude state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
