EnricoMi commented on code in PR #1933:
URL:
https://github.com/apache/incubator-uniffle/pull/1933#discussion_r1683829802
##########
docs/coordinator_guide.md:
##########
@@ -36,6 +36,11 @@ This document will introduce how to deploy Uniffle
coordinators.
HADOOP_HOME=<hadoop home>
XMX_SIZE="16g"
```
+ Besides, you can add extra jvm arguments for shuffle server by specific
`UNIFFLE_COORDINATOR_JAVA_OPTS` in `rss-env.sh`
+ Something like:
Review Comment:
```suggestion
You can add extra JVM arguments for the Uniffle coordinator by specifying
`UNIFFLE_COORDINATOR_JAVA_OPTS` in `rss-env.sh`.
Example:
```
##########
docs/server_guide.md:
##########
@@ -174,6 +174,14 @@ XMX_SIZE=40g
MAX_DIRECT_MEMORY_SIZE=360g
```
+Besides, you can add extra jvm arguments for shuffle server by specific
`UNIFFLE_SHUFFLE_SERVER_JAVA_OPTS` in `rss-env.sh`
+
+Something like:
Review Comment:
```suggestion
You can add extra JVM arguments for the Uniffle shuffle server by specifying
`UNIFFLE_SHUFFLE_SERVER_JAVA_OPTS` in `rss-env.sh`
Example:
```
##########
docs/dashboard_guide.md:
##########
@@ -32,6 +32,13 @@ rss.dashboard.http.port 19997
coordinator.web.address http://coordinator.hostname:19998/
```
+### Configure related JVM parameters
+you can add extra jvm arguments for shuffle server by specific
`UNIFFLE_DASHBOARD_JAVA_OPTS` in `RSS_HOME/bin/rss-env.sh`
+Something like:
Review Comment:
```suggestion
You can add extra JVM arguments for the Uniffle dashboard by specifying
`UNIFFLE_DASHBOARD_JAVA_OPTS` in `RSS_HOME/bin/rss-env.sh`
Example:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
